[SOLVED] inspector crashes on closure

[tkoning]

hi

i've upgraded to the latest version of openplotter
opening inspector works fine, closing it is not possible

@openplotter:~ $ Traceback (most recent call last):
  File "/home/pi/.config/openplotter/output.py", line 205, in OnClose
    self.mqtt.stop()
  File "/home/pi/.config/openplotter/classes/mqtt.py", line 68, in stop
    self.client.loop_stop()
AttributeError: Mqtt instance has no attribute 'client'

I've created the mosquito password file as described in the other mqtt bug fix on this forum

[holgerw]

opening inspector works fine, closing it is not possible

The same here - something broken in the close bow of inspector....

[Alpenskipper]

opening inspector works fine, closing it is not possible

The same here - something broken in the close bow of inspector....

I think it has something to do with the mqtt topic settings.

When defining a topic in mqtt I get the following error report. It is not only the Inspector that crashes, I can't send sensor data, either.

When deleting all mqtt topics, everything is working again after Openplotter is restarted.

With topics defined:

pi@openplotter:~ $ python /home/pi/.config/openplotter/openplotter.py
Traceback (most recent call last):
  File "/home/pi/.config/openplotter/output.py", line 211, in <module>
    MyFrame().Show()
  File "/home/pi/.config/openplotter/output.py", line 65, in __init__
    self.reset(0)
  File "/home/pi/.config/openplotter/output.py", line 187, in reset
    self.mqtt=Mqtt(self.conf,self.a)
  File "/home/pi/.config/openplotter/classes/mqtt.py", line 37, in __init__
    self.client_local.connect(local_broker, local_port)
  File "/usr/local/lib/python2.7/dist-packages/paho/mqtt/client.py", line 612, in connect
    return self.reconnect()
  File "/usr/local/lib/python2.7/dist-packages/paho/mqtt/client.py", line 734, in reconnect
    sock = socket.create_connection((self._host, self._port), source_address=(self._bind_address, 0))
  File "/usr/lib/python2.7/socket.py", line 571, in create_connection
    raise err
socket.error: [Errno 111] Connection refused


After deleting the mqtt topic (=without mqtt), all is fine again.

Failed to restart mosquitto.service: Unit mosquitto.service failed to load: No such file or directory.
Traceback (most recent call last):
  File "/home/pi/.config/openplotter/output.py", line 205, in OnClose
    self.mqtt.stop()
  File "/home/pi/.config/openplotter/classes/mqtt.py", line 68, in stop
    self.client.loop_stop()
AttributeError: Mqtt instance has no attribute 'client'

Martin

[Sailoog]

bug detected and solved on v0.8.0. Thanks guys. It was an error related to mqtt feature, when no connection was established inspector window was trying to close a service that didn't exist.

Test please.

v0.8.0 branch has been merged to the master branch now, so to update from previous 0.8.0 versions:

Code:

cd
cd .config
rm -rf openplotter/
git clone https://github.com/sailoog/openplotter.git

to update from 0.7.0: http://www.sailoog.com/en/blog/test-open...r-v080beta

Thanks for reporting!

[tkoning]

bug detected and solved on v0.8.0. Thanks guys. It was an error related to mqtt feature, when no connection was established inspector window was trying to close a service that didn't exist.

Test please.

v0.8.0 branch has been merged to the master branch now, so to update from previous 0.8.0 versions:

Code:

cd
cd .config
rm -rf openplotter/
git clone https://github.com/sailoog/openplotter.git

to update from 0.7.0: http://www.sailoog.com/en/blog/test-open...r-v080beta

Thanks for reporting!

Works for me, inspector opens and closes without problems

thx for the fix     

[Didier B]

When updating from 0.7.1, the 'git clone ...'  command request an authentification (username for 'https://github.com' , and probably next step a password...)

[Sailoog]

We are close to v0.8.0 stable so I have merged all the branches, now there is only the master branch. You do not need to update 0.7.1, just to wait for 0.8.0 release.

Right:

Code:

git clone https://github.com/sailoog/openplotter.git

Wrong:

Code:

git clone -b v0.7.1 https://github.com/sailoog/openplotter.git

[Didier B]

Ooooops, typo mistake !