This forum uses cookies
This forum makes use of cookies to store your login information if you are registered, and your last visit if you are not. Cookies are small text documents stored on your computer; the cookies set by this forum can only be used on this website and pose no security risk. Cookies on this forum also track the specific topics you have read and when you last read them. Please confirm whether you accept or reject these cookies being set.

A cookie will be stored in your browser regardless of choice to prevent you being asked this question again. You will be able to change your cookie settings at any time using the link in the footer.
OpenMarine › OpenPlotter › Bug Reports v
[SOLVED] Chaging theme to dark colors and I can't see stuff in OpenPlotter

Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
[SOLVED] Chaging theme to dark colors and I can't see stuff in OpenPlotter
mgrouch Offline
Member
***
Posts: 103
Threads: 41
Joined: Mar 2018
Reputation: 7
#1
2020-03-31, 04:58 AM (This post was last modified: 2020-04-03, 11:54 AM by Sailoog.)
There are seems places in OpenPlotter programs where colors are hard coded.
There is yellow for row selection and there is while fond color in OpenPlotter module install.

When I switched my desktop theme to dark colors (White fond on dark menus)
everything is fine in Raspberry Pi UI (OpenBox, etc)

but in those two places in OpenPlotter set of programs I can't see anything.
It becomes white on yellow or white on white.

The colors everywhere should come from the UI theme.
Unless application manages all colors by itself.

Thanks,
--MG
https://bareboat-necessities.github.io/my-bareboat/
Website Find
Reply
Sailoog Offline
Administrator
*******
Posts: 1,708
Threads: 39
Joined: Mar 2016
Reputation: 120
#2
2020-03-31, 12:57 PM
I am not sure wxpython can do that. Do you have any screenshot?
Find
Reply
mgrouch Offline
Member
***
Posts: 103
Threads: 41
Joined: Mar 2018
Reputation: 7
#3
2020-03-31, 07:25 PM (This post was last modified: 2020-03-31, 07:45 PM by mgrouch.)
(2020-03-31, 12:57 PM)Sailoog Wrote: I am not sure wxpython can do that. Do you have any screenshot?

Here are examples
Thanks
(2020-03-31, 07:25 PM)mgrouch Wrote:
(2020-03-31, 12:57 PM)Sailoog Wrote: I am not sure wxpython can do that. Do you have any screenshot?

Here are examples
Thanks

I think everywhere where you change background color to some hardcoded value in the code
you also have to change font color for that area. Otherwise you can't assume
the font is going to be readable.
Thanks,
--MG


Attached Files Image(s)
       
https://bareboat-necessities.github.io/my-bareboat/
Website Find
Reply
Sailoog Offline
Administrator
*******
Posts: 1,708
Threads: 39
Joined: Mar 2016
Reputation: 120
#4
2020-04-01, 07:48 PM
I think the problem is not with rows background color but text color. In your screenshots this text is white, how do you set this dark mode?

This make me realize that we would need a "Dark mode" button in main menu...
Find
Reply
mgrouch Offline
Member
***
Posts: 103
Threads: 41
Joined: Mar 2018
Reputation: 7
#5
2020-04-01, 08:01 PM
I run lxappearance and changed the theme to Breeze-Dark.
You can install that theme using Add / Remove Software searching for a word 'Breeze'.

Thanks,
--MG
https://bareboat-necessities.github.io/my-bareboat/
Website Find
Reply
Sailoog Offline
Administrator
*******
Posts: 1,708
Threads: 39
Joined: Mar 2016
Reputation: 120
#6
2020-04-02, 07:29 PM
We can not change the background color of rows because yellow means SK, blue means N2K and green means NMEA 0183. Your problem is that using a dark theme the text of the programs is set to white so the solution is hardcoding the color of lists in openplotter to be always black.
Find
Reply
mgrouch Offline
Member
***
Posts: 103
Threads: 41
Joined: Mar 2018
Reputation: 7
#7
2020-04-02, 08:14 PM
(2020-04-02, 07:29 PM)Sailoog Wrote: We can not change the background color of rows because yellow means SK, blue means N2K and green means NMEA 0183. Your problem is that using a dark theme the text of the programs is set to white so the solution is hardcoding the color of lists in openplotter to be always black.

Yes, that's why the font color needs to change for the contrast.

Thanks,
--MG
https://bareboat-necessities.github.io/my-bareboat/
Website Find
Reply
Sailoog Offline
Administrator
*******
Posts: 1,708
Threads: 39
Joined: Mar 2016
Reputation: 120
#8
2020-04-03, 11:52 AM (This post was last modified: 2020-04-03, 11:54 AM by Sailoog.)
I have forced black color to the text of all apps containing rows. Since this is a minor change I will wait for more changes to publish a new version of every app. Thanks.

Marking this thread as solved...
Find
Reply
mgrouch Offline
Member
***
Posts: 103
Threads: 41
Joined: Mar 2018
Reputation: 7
#9
2020-04-07, 05:25 PM
(2020-04-03, 11:52 AM)Sailoog Wrote: I have forced black color to the text of all apps containing rows. Since this is a minor change I will wait for more changes to publish a new version of every app. Thanks.

Marking this thread as solved...

Hardcoding of colors is present not just in rows. 
It is more widespread. Here is one more screen shot:

Thanks,
--MG


Attached Files Image(s)
   
https://bareboat-necessities.github.io/my-bareboat/
Website Find
Reply
Sailoog Offline
Administrator
*******
Posts: 1,708
Threads: 39
Joined: Mar 2016
Reputation: 120
#10
2020-04-08, 06:12 PM
This time the problem is with window background. It is not getting the color of your theme. If it can not be fixed the solution could be hardcoding the text to black just as we did with lists.

Just to be clear, text hardcoding is not the problem, it is just the opposite.
Find
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)